Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an internal QueryPartListView class #9986

Closed
lukaseder opened this issue Mar 24, 2020 · 1 comment
Closed

Add an internal QueryPartListView class #9986

lukaseder opened this issue Mar 24, 2020 · 1 comment

Comments

@lukaseder
Copy link
Member

The existing QueryPartList class is a list. Its constructors copy the arguments. In many cases, this is wasteful and unnecessary. A new QueryPartListView class that doesn't copy the argument list would cause less copying overhead, and help make list generation and formatting logic more reusable (see #9985)

@lukaseder
Copy link
Member Author

Now that we have this utility, it will make sense to also add some formatting hints. E.g. to specify from outside:

  • The separator character(s) (e.g. Statement doesn't use ,, but nothing)
  • Whether the list indents on size() > 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant