Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rust code an external project and build header file automatically #732

Merged
merged 5 commits into from
Nov 20, 2018
Merged

Make rust code an external project and build header file automatically #732

merged 5 commits into from
Nov 20, 2018

Conversation

selaux
Copy link
Member

@selaux selaux commented Oct 14, 2018

  • Make rust code an external project
  • Generate headers for rust library automatically using cbindgen
  • Merges some of the external project code for the 3 external projects

@selaux selaux changed the title External project rust Make rust code an external project and build header file automatically Oct 14, 2018
@lynxlynxlynx
Copy link
Member

Reading diagonally, it looks ok. The first commit seems to have unrelated older work though.

@selaux
Copy link
Member Author

selaux commented Oct 14, 2018

Those are changes needed because of aliasing the C and Rust enums for GameVersion and ResourceVersion and ScalingQuality to VideoScalingQuality. The names for the C variants had to be changed there.

@selaux
Copy link
Member Author

selaux commented Nov 20, 2018

Can this be merged?

@lynxlynxlynx lynxlynxlynx merged commit c633cf3 into master Nov 20, 2018
@lynxlynxlynx lynxlynxlynx deleted the external-project-rust branch November 20, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selaux @lynxlynxlynx