Add ramp-padding capabilities to module/cpu #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes polybar play nice with the i3wm feature `workspace_auto_back_and_forth`, and it is harmless when that option isn't set.
Changelog Fixes: * fix(ramp): Evenly distribute states (polybar#1340), see polybar#1328 * fix(i3): Play nice with workspace_auto_back_and_forth (polybar#1312) * fix(controller): don't draw window if writing to stdout (polybar#1322), see polybar#1314
patrick96
requested changes
Oct 15, 2018
src/modules/cpu.cpp
Outdated
| @@ -18,6 +18,8 @@ namespace modules { | |||
| cpu_module::cpu_module(const bar_settings& bar, string name_) : timer_module<cpu_module>(bar, move(name_)) { | |||
| m_interval = m_conf.get<decltype(m_interval)>(name(), "interval", 1s); | |||
|
|
|||
| m_ramp_padding = m_conf.get<decltype(m_ramp_padding)>(name(), "ramp-padding"); | |||
There was a problem hiding this comment.
In the PR we discussed naming it ramp-coreload-spacing, which also makes more sense, since it only affects the coreload ramp and not the other ramps.
Should also have a default value of 1.
There was a problem hiding this comment.
I'll get right on that! Sorry I missed it the first time.
patrick96
approved these changes
Oct 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
=========================================
- Coverage 5.78% 5.78% -0.01%
=========================================
Files 162 162
Lines 9030 9031 +1
=========================================
Hits 522 522
- Misses 8508 8509 +1
Continue to review full report at Codecov.
|
patrick96
added a commit
that referenced
this pull request
Oct 15, 2018
This reverts commit 06adef1.
patrick96
added a commit
that referenced
this pull request
Oct 15, 2018
This reverts commit 06adef1.
|
Oh damn. Because you originally created a PR against the |
|
So is there anything else I need to do resolve that or is it taken care of? |
patrick96
added a commit
that referenced
this pull request
Oct 15, 2018
|
No, everything is taken care of. I have taken the commits you made and applied them to the master branch and openened a PR for that. |
patrick96
pushed a commit
to patrick96/polybar
that referenced
this pull request
Nov 17, 2018
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Nov 17, 2018
This reverts commit 06adef1.
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Nov 17, 2018
patrick96
added a commit
that referenced
this pull request
Dec 23, 2018
### Breaking Changes: None ### Changelog **New Config Options** The following config options were added In the `[settings]` section: * `pseudo-transparency` In `internal/cpu`: * `ramp-coreload-spacing`, spacing between elements in `<ramp-coreload>` elements * `%percentage-sum%` in `label`. Shows sum of all percentages In `custom/script`: * `double-click-left` * `double-click-middle` * `double-click-right` In `internal/pulseaudio`: * `interval`, volume increase and decrease steps in percentage points In `internal/memory`: * `bar-swap-used` * `bar-swap-free` * `ramp-swap-used` * `ramp-swap-free` **Deprecations** * `tray-transparent` in the bar section is no longer used. The tray now always uses pseudo-transparency **Features** * volume: adjustable volume steps (#1364), see #1361 * memory: Add progress bars and ramps for swap (#1325) * render: pseudo-transparency (always used in the tray) (#595) * cpu: * Configurable spacing in between coreloads (#1472), see #1389 * Non-normalized cpu load (#1517), see #1516 * script: Double click actions (#1442) * net: Support for bridge interfaces (#1528), see #1522 * token: zero pad tokens when min-width value starts with a `0` (#1341), see #1332 **Fixes** * config: Use font patterns detected on system in sample config (#1350) * net: Disconnected module when SSID is only an emoji (#1371), see #1367 * tray: Tray overlapping with bar (#1392), see #591 * build: Several build errors (#1395, #1454, #1470, polybar/xpp#12, #1493), see #1447, #1469, #750, #1492 * mpd: format-online-prefix not working (#1402), see #1399 * font: Crash for some font-patterns (#1451), see #1435 * script: * Only `%counter%` or `%pid%` token usable, never both (#1456) * click actions with colons in them (#1457), see #984 * renderer: Bar locks up when xorg composite extension is disabled (#1430), see #1425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1389
Allows "ramp-padding" in polybar config file to adjust spacing between core loads.