Refactor Connection Management and Update Unit Tests for Improved Robustness #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes several updates to the project: 1. Added a 'test:watch' script to package.json to enable running jest in watch mode. 2. Refactored the manager tests to improve readability and test coverage. 3. Updated the type of logQueue from a tuple to an Array in manager.ts. These changes are intended to improve the developer experience and maintainability of the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several key changes to the management of connections and the associated unit tests:
Refactored Connection class into an abstract class with two concrete implementations - PlainConnection and SecureConnection. This allows better handling of different connection types and improves code readability and maintainability.
Updated the Manager class to handle connection errors, retries, and logging better. This includes adding event listeners for various connection events and implementing a retry mechanism for retriable errors.
Updated unit tests to reflect these changes and to better test the new logic. Tests now cover plain and secure connections and check the correct handling of log entries and queue flushing.
These changes are intended to improve the robustness of the connection management and to ensure that the system handles errors and retries appropriately.