Skip to content
This repository has been archived by the owner on Jul 22, 2019. It is now read-only.

Request - GPX Build in #977

Open
NoobWithBoobs opened this issue Aug 11, 2016 · 68 comments
Open

Request - GPX Build in #977

NoobWithBoobs opened this issue Aug 11, 2016 · 68 comments

Comments

@NoobWithBoobs
Copy link

NoobWithBoobs commented Aug 11, 2016

Hello,
Requesting for GPX following to be build in to json/config file. Keep the bot from traveling off course.

Do-able?

@ghost
Copy link

ghost commented Aug 11, 2016

Would be interesting

@NoobWithBoobs
Copy link
Author

NoobWithBoobs commented Aug 11, 2016

would be ideal for a nest area and gpx are pretty easy to make with google earth and bunch of other programs too.

@ghost
Copy link

ghost commented Aug 11, 2016

Support for GPX was already in the previous version of the GUI so it shouldn't be too hard to implement

@NoobWithBoobs
Copy link
Author

NoobWithBoobs commented Aug 11, 2016

I have the bot reload every 30mins due and usually i'm not around to resubmit via the gui again and again. If gpx support was build into config/json file, bot could roam around in more focus areas without having to be instructed to each and every time. .

@ghost
Copy link

ghost commented Aug 11, 2016

Just checked, it's do-able

@NoobWithBoobs
Copy link
Author

The excitement rages!!!

@staurakis
Copy link

It would be a great add on!!! :)

@ghost
Copy link

ghost commented Aug 11, 2016

Will do it today or tomorrow

@NoobWithBoobs
Copy link
Author

i look forward to it, keep us posted here 👍

@ghost
Copy link

ghost commented Aug 11, 2016

Will have two settings I think :

  • GPX file
  • Number of time the file must be repeated

@NoobWithBoobs
Copy link
Author

Repeat is an awesome idea, please be sure to include -1 option as well.

@ghost
Copy link

ghost commented Aug 11, 2016

Of course ^^

@ncovercash
Copy link

How can I make this kind of GPX?

@NoobWithBoobs
Copy link
Author

Easist ways to make GPX files online
http://www.gpsies.com/createTrack.do?language=en

@NoobWithBoobs
Copy link
Author

@Peyphour Direction might be cool in future versions.

@ghost
Copy link

ghost commented Aug 11, 2016

Directions ?

@NoobWithBoobs
Copy link
Author

Direction as in backwards, forward, bidirectional.

@staurakis
Copy link

I think the only logical route to have is a circular one... There is no point to directly go back the opposite route as nothing would have been spawn yet.
On the other hand, a delay time maybe a good idea if you have a small route ;)

@NoobWithBoobs
Copy link
Author

@staurakis, you do have a point with circular routes but I was thinking long roads and such. Anyways, I'm excited for just the basic, I could make a loop myself.

Delay Time to wait for Pokemon to spawn?

@staurakis
Copy link

staurakis commented Aug 11, 2016

Me too! ;)
@NoobWithBoobs yes a delay amount of time to wait to restart the route i think would be a nice think to have :)

@ghost ghost mentioned this issue Aug 11, 2016
@ghost
Copy link

ghost commented Aug 11, 2016

#1008

@NoobWithBoobs
Copy link
Author

damn exciting, can't wait to see it be included in the main build!!

@ghost
Copy link

ghost commented Aug 11, 2016

Can you test it ? I can't do it right now ^^

@NoobWithBoobs
Copy link
Author

yep, pulling as I type!

@NoobWithBoobs
Copy link
Author

NoobWithBoobs commented Aug 11, 2016


ink.abb.pogo.scraper.TestSettings > testDefaultSettings FAILED
    java.io.FileNotFoundException at TestSettings.kt:25

ink.abb.pogo.scraper.TestSettings > testTemplateKeys FAILED
    java.io.FileNotFoundException at TestSettings.kt:73

2 tests completed, 2 failed
:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///Users/Katherine/Desktop/Beta/PokemonGoBot/build/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 10 mins 37.845 secs

Happened on your end as well?

@ghost
Copy link

ghost commented Aug 11, 2016

10min for building ?!

Are you sure you have a config.properties.template ? Build passed on Travis so this isn't my fault

@NoobWithBoobs
Copy link
Author

mhmm redo time!

@NoobWithBoobs
Copy link
Author

NoobWithBoobs commented Aug 11, 2016

So I've tested it now for 20mins and I don't see it following the gpx patch. Could you provide your gpx file and which one is correct?

# GPX file to be added on the bot's start
gpx_file=/Users/Katherine/Desktop/Beta/PokemonGoBot/WalkInCentralPark.gpx
# Number of times the bot must repeat this GPX file
gpx_repeat=-1

or

# GPX file to be added on the bot's start
gpx_file=WalkInCentralPark.gpx
# Number of times the bot must repeat this GPX file
gpx_repeat=-1

@staurakis
Copy link

@NoobWithBoobs i'm willing to help by any means (and that's obvious i think) but i'm a bit out of my expertise here... If i receive some rough guidelines, i can and will be more than happy to do so! :)

@ghost
Copy link

ghost commented Aug 12, 2016

Just run the bot with a GPX file, let it run for 4-5 minutes et send me : the GPX file and the logs

@staurakis
Copy link

i have the compiled version @Peyphour .... As far as i understand, i have to go for the other way to run it and get the files you have changed.... That is the part i am missing.... That's the part that i need a bit of info. I am missing the platform to 'compile' it.... I think at least.....

@ghost
Copy link

ghost commented Aug 12, 2016

Forget it then, I'll do it myself tomorrow

@staurakis
Copy link

staurakis commented Aug 12, 2016

i think i did it.... building it right now....
I will test it with my gpx and let you know ;)
pffff :(
Download https://repo1.maven.org/maven2/com/fasterxml/classmate/1.1.0/classmate-1.1.0.jar
:compileKotlin
:compileJava FAILED

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':compileJava'.

    Could not find tools.jar. Please check that C:\Program Files (x86)\Java\jre1.8.0_101 contains a valid JDK installation.

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 51.099 secs

@staurakis
Copy link

fixed it...continuing.....

@ghost
Copy link

ghost commented Aug 12, 2016

Sorry, didn't see your issue, you need JDK 1.8

@staurakis
Copy link

yeap yeap figured it out ;)
checking the gpx right now ;)

@staurakis
Copy link

@Peyphour my gpx format is a bit different from your test.gpx.
Also, don't you have any 'switch' (as you describe in your code) in the configuration file? I haven't seen anything.

@staurakis
Copy link

I have added two variables in to the configuration file: gpxFile and gpxRepeat in a try to make it read my gpx file but without any luck.
I have also changed my gpx xml file in accordance to your xml but again it didn't help.
@Peyphour Could you please help on how to make it "read" the gpx file?

@ghost
Copy link

ghost commented Aug 12, 2016

What do you mean by 'switch' ?
Could you provide via pastebin your config file and GPX file ?

@staurakis
Copy link

i think i found it.... you name your variables with _ in between. I had them in the configuration file as you describe them in the comments without anything.
Testing again.

@staurakis
Copy link

staurakis commented Aug 12, 2016

my config file now is like that:

GPX file to be added on the bot's start
gpx_file=test.gpx
Number of times the bot must repeat this GPX file
gpx_repeat=5

gpx file: http://pastebin.com/UAZpj1X5

@staurakis
Copy link

I can get it "read" the gpx file.... :(
@Peyphour Am i doing something wrong....?

@ghost
Copy link

ghost commented Aug 12, 2016

Can't help you at the moment, it's 11 PM here in Paris, we can talk about this tomorrow

@staurakis
Copy link

ok. whenever you can

@ghost
Copy link

ghost commented Aug 15, 2016

Hello, any updates ? Do you still need help ?
I've got some free time, let's solve this 😄

@staurakis
Copy link

Yes i need help on this. I couldn't make it 'read' the gpx file. Basicaly it didn't do anything.
Although currently i have paused testing due to ban issue, i will begin again in few hours. So if tou please help on this...

@NoobWithBoobs
Copy link
Author

Be care, I'm ban. I propose catch, stop, and time limit to avoid getting banned.

@alexbulyha
Copy link
Contributor

I have added those 3 limits, however they currently simply stop (not kill) the bot, without restarting it later vor anything like that
In #1047

@NoobWithBoobs
Copy link
Author

@AlexBoulyga, very nice. Checking it out

@alexbulyha
Copy link
Contributor

If you find any bugs in that functionality (try it out with low values) Please tell me. However, AS a Warning, it currently stops the bot but the process seems to still run, so you need to kill it manually (idk why)

@ghost
Copy link

ghost commented Aug 15, 2016

A little off topic here guys :)
@staurakis, what did you try to make it work ? The options are 'gpxFile' (the path MUST be relative to the jar file/project if you build from source), and 'gpxRepeat' (any value >0 works, 1 should be good for testing)

@NoobWithBoobs
Copy link
Author

@peyphour, you're right. @AlexBoulyga I'll report back as soon as I get a chance. Currently at work.

@peyphour, considering the recent bans that we've all been impacted by. Would it possible if the bot didn't follow the gpx perfectly. Meaning the path stays the same but the coordinates numbers have a bit of change. So it seems less like a bot and more like a drunk/teenager person walking.

@ghost
Copy link

ghost commented Aug 15, 2016

Yeah there's already a part of the code which does some randomization, I will adapt it

@NoobWithBoobs
Copy link
Author

@Peyphour Genius!

@ghost
Copy link

ghost commented Aug 15, 2016

Actually, I just re-checked and the randomization of the path is done for every coordinate supplied to the bot (including when going to pokestop, catching pokemons etc ...)

@ghost
Copy link

ghost commented Aug 16, 2016

I did a test and it works for me, double check your settings

@NoobWithBoobs
Copy link
Author

By chance, would you share your settings with us? Maybe we're missing something

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants