This repository has been archived by the owner on Jul 22, 2019. It is now read-only.
Add GPX support #1008
Open
Add GPX support #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Not ready to merge yet |
| Log.green("GPX plugin : reading file " + settings.gpxFile + " with $i repeats") | ||
|
|
||
| // gpxRepeat == 0 or -1 : No coordinates will be added | ||
| while(i > 0) { |
There was a problem hiding this comment.
Could you maybe put this in a task to add the next iteration when the previous ended. That way an "infinite" option is possible in a "clean" way (instead of adding your route eg "99999" times, which can be very memory intensive)
|
Still needed ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: #977
Changes made: