Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/2423 align admin with section 2d3d qualifications changes #2457

Merged

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented Jun 24, 2024

What's included?

closes #2423

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Screenshot 2024-06-25 at 11 04 50

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jun 24, 2024

Visit the preview URL for this PR (updated for commit 779aafd):

https://jac-admin-develop--pr2457-feat-2423-align-admi-o5n9agb4.web.app

(expires Fri, 26 Jul 2024 16:24:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@nickaddy
Copy link
Contributor

@KoWeiJAC This is not working for me. First of all, there was no option set under eligibility in set-up (you have to choose 2d or 2(3). I've now set it to 2d and at that point the Are you applying under section 2d appeared. However, irrespective of my answer, None of the above appears in the dropdown. Also, it doesn't appear to reset when the initial answer to Are you applying under... changes.

Copy link
Contributor

@Franceswog Franceswog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought when you click 'No' the window below (Explain how etc) should not appear. It should only appear when you click 'Yes', which allows the candidate to explain how they gained their experience in law..

image

@KoWeiJAC
Copy link
Contributor Author

I would have thought when you click 'No' the window below (Explain how etc) should not appear. It should only appear when you click 'Yes', which allows the candidate to explain how they gained their experience in law..

image

@Franceswog
I've had a change for it can remove 'Explain how...' question after selecting 'No' for the schedule question.
Originally, it remove the 'Explain how...' after click 'save' for the schedule question.
Could you help me to confirm if it is ok ? Thanks

Screen.Recording.2024-06-26.at.17.33.13.mov

@KoWeiJAC
Copy link
Contributor Author

@KoWeiJAC This is not working for me. First of all, there was no option set under eligibility in set-up (you have to choose 2d or 2(3). I've now set it to 2d and at that point the Are you applying under section 2d appeared. However, irrespective of my answer, None of the above appears in the dropdown. Also, it doesn't appear to reset when the initial answer to Are you applying under... changes.

@KoWeiJAC This is not working for me. First of all, there was no option set under eligibility in set-up (you have to choose 2d or 2(3). I've now set it to 2d and at that point the Are you applying under section 2d appeared. However, irrespective of my answer, None of the above appears in the dropdown. Also, it doesn't appear to reset when the initial answer to Are you applying under... changes.

@nickaddy
Not sure if the exercise being reset, I set it to schedule 2(3) originally, thank you for fixing it.

I've had following changes:

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoWeiJAC 👍

Copy link
Contributor

@NormaJAC NormaJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works

@KoWeiJAC KoWeiJAC merged commit 012adf3 into main Jul 1, 2024
6 checks passed
@KoWeiJAC KoWeiJAC deleted the feat/2423-align-admin-with-Section-2d3d-qualifications-changes branch July 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align Admin with Section 2d/3d qualifications changes on Apply
7 participants