Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working preferences questions #1072

Closed
8 of 9 tasks
warrensearle opened this issue Sep 28, 2023 · 3 comments · Fixed by #1135
Closed
8 of 9 tasks

Working preferences questions #1072

warrensearle opened this issue Sep 28, 2023 · 3 comments · Fixed by #1135
Assignees
@warrensearle @tomlovesgithub @drieJAC

Comments

@warrensearle
Copy link
Member

warrensearle commented Sep 28, 2023 •
edited
Loading

See Admin: Configure working preferences questions

There are a number of configuration changes outlined in Configure working preferences questions.

Here we need to ensure these changes are correctly rolled out to the application form.

In particular:

Improvements to existing functionality

  • Working preferences questions should be mandatory (if configured)
  • Ranking. Should not be able to skip numbers - e.g. choosing two answers from five means user can choose 1st and 2nd choice, not 1st and 5th
  • There can now be multiple location questions (currently there is only one)
  • There can now be multiple jurisdiction questions (currently there is only one)

Use Jurisdictions from Vacancy Information

  • Ensure that we display answers from Vacancy Information > Jurisdictions if the question is configured

Allow linked questions

  • Ensure linked questions are only asked if the corresponding linked answer has been selected
  • Improve the navigation / ensure we ask linked questions from another preference type (either combine the preference questions into one page OR ensure linked questions from another preference are asked on both preference pages)

Allow grouping of answers

  • Display answer groups and nested answers

Review

  • Update the Review page to correctly display the candidate's selections

https://github.com/jac-uk/apply/assets/8524401/3d87a3cd-c129-4f51-8a8c-279cb918105e

See the following visuals
@tomlovesgithub
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @warrensearle @HalcyonJAC

@warrensearle
Copy link
Member Author

Please add your planning poker estimate with Zenhub @drieJAC

@warrensearle warrensearle mentioned this issue Oct 9, 2023
Closed
9 tasks
@warrensearle warrensearle self-assigned this Oct 9, 2023
@drieJAC drieJAC assigned drieJAC and unassigned drieJAC Oct 30, 2023
warrensearle added a commit that referenced this issue Jan 23, 2024
@warrensearle
#1072 Working preferences questions
eefedd0
@warrensearle warrensearle mentioned this issue Jan 23, 2024
Merged
8 tasks
@tomlovesgithub tomlovesgithub self-assigned this Jan 29, 2024
@tomlovesgithub
Copy link
Contributor

tomlovesgithub commented Jan 29, 2024 •
edited
Loading

Note to self

  • sign into apply
  • find working prefs examples 708 develop
  • all review pages (admin ex conf and apply final reviews)

think on data shape - are ids needed

(👀 admin 2154)

This was referenced Feb 19, 2024
Open
Open
@warrensearle warrensearle assigned drieJAC and unassigned warrensearle Feb 19, 2024
@warrensearle warrensearle self-assigned this Mar 14, 2024
@nickaddy nickaddy reopened this May 31, 2024
warrensearle added a commit that referenced this issue Jul 1, 2024
@warrensearle @tomlovesgithub
@drieJAC @HalcyonJAC
#1072 Working preferences questions (#1135)
137e29e 
* #1072 Working preferences questions

* Handle missing preferences

* Keep form data clean

* Include validation

* Add `npm run develop:serve` command

* location prefs + jurisdiction prefs

* only displaying new questions AWP squashed display

* displaying all questions

* displays old questionsa and new, styling correcy

* Allow ranked answers than can be the same.
Add validation to ensure an error is shown for gaps in integers and if 1 is omitted.
Ensure other validators return false after setting the error message.

* When selecting how many questions candidates need to select this commit changes the label 'Some' to 'At least' and adds 'exactly' as a new option.

* Added support for optional/required fields. As such had to ensure the Save And Continue button is always active.

* Fixed validation of date object issue and ensuring if there is an error due to an existing email address the ui scrolls to the top of the page to show it.

* Store IDs of questions and answers

* Fix lint error

* Fix display of linked questions

* Fix lint :)

* Updated working preferences

* used jac-kit components

* Update to use latest jac-kit

* Update package-lock

* Invitations should use latest firebase code

* PSDQ should use latest firebase code

* #1162 Update preferences questions

- task list
- forms

* Bugfix/1161 PSDQ Character Checks (#1164)

* fix error in console

* fix lint

* Bugfix/1162 PSDQ Working Preferences (#1168)

* fix QuestionRenderer

* update jac-kit version

* check if preferences exist

* Update package-lock

* Update to use latest jac-kit

* Prioritise the display of orginal questions over new

* Tidy up code

* Update package-lock

* Fix lint errors

* Tidy components

* Move QuestionInput to Form components

* Move questioninput to forms ctd

* Fix validation of 'exactly' answers

* Support 'other' jurisdictions in master list

* Fix 'exactly' validation for ranked questions

* Update package-lock

---------

Co-authored-by: Tom Russell <TR115251@hotmail.co.uk>
Co-authored-by: drieJac <jac.drie@digitalteam.uk>
Co-authored-by: Ryan Hsieh <79906532+HalcyonJAC@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warrensearle warrensearle

@tomlovesgithub tomlovesgithub

@drieJAC drieJAC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1072 Working preferences questions jac-uk/apply
4 participants
@warrensearle @tomlovesgithub @drieJAC @nickaddy