Bugfix/1162 PSDQ Working Preferences #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9fe9d10): https://jac-apply-develop--pr1168-bugfix-1162-psdq-wor-m9x65ove.web.app (expires Sat, 01 Jun 2024 09:16:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ac0a9c931657844a433a502135cf38aca21627 |
HalcyonJAC
requested review from
NormaJAC,
tomlovesgithub,
drieJAC,
KoWeiJAC,
warrensearle and
a team
and removed request for
a team,
NormaJAC and
KoWeiJAC
drieJAC
approved these changes
May 3, 2024
tomlovesgithub
approved these changes
May 3, 2024
warrensearle
merged commit c927eae
into
feature/1072-working-preferences
4 checks passed
warrensearle
added a commit
that referenced
this pull request
Jul 1, 2024
* #1072 Working preferences questions * Handle missing preferences * Keep form data clean * Include validation * Add `npm run develop:serve` command * location prefs + jurisdiction prefs * only displaying new questions AWP squashed display * displaying all questions * displays old questionsa and new, styling correcy * Allow ranked answers than can be the same. Add validation to ensure an error is shown for gaps in integers and if 1 is omitted. Ensure other validators return false after setting the error message. * When selecting how many questions candidates need to select this commit changes the label 'Some' to 'At least' and adds 'exactly' as a new option. * Added support for optional/required fields. As such had to ensure the Save And Continue button is always active. * Fixed validation of date object issue and ensuring if there is an error due to an existing email address the ui scrolls to the top of the page to show it. * Store IDs of questions and answers * Fix lint error * Fix display of linked questions * Fix lint :) * Updated working preferences * used jac-kit components * Update to use latest jac-kit * Update package-lock * Invitations should use latest firebase code * PSDQ should use latest firebase code * #1162 Update preferences questions - task list - forms * Bugfix/1161 PSDQ Character Checks (#1164) * fix error in console * fix lint * Bugfix/1162 PSDQ Working Preferences (#1168) * fix QuestionRenderer * update jac-kit version * check if preferences exist * Update package-lock * Update to use latest jac-kit * Prioritise the display of orginal questions over new * Tidy up code * Update package-lock * Fix lint errors * Tidy components * Move QuestionInput to Form components * Move questioninput to forms ctd * Fix validation of 'exactly' answers * Support 'other' jurisdictions in master list * Fix 'exactly' validation for ranked questions * Update package-lock --------- Co-authored-by: Tom Russell <TR115251@hotmail.co.uk> Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: Ryan Hsieh <79906532+HalcyonJAC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Closes #1162
Related PR: jac-kit: Bugfix/QuestionRenderer #184
Who should test?
✅ Product owner
✅ Developers
How to test?
Application
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, notes etc.
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING