Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1204 Mandate NINo field in Personal details section of Application form #1205

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jul 29, 2024

What's included?

Closes #1204

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Example vacancy

Steps:

  1. Apply for the vacancy.
  2. Go to the Personal details section.
  3. Check if the field "National Insurance number" is mandatory.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, notes etc.


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jul 29, 2024

Visit the preview URL for this PR (updated for commit 6d8f9bd):

https://jac-apply-develop--pr1205-feature-1204-mandate-ypbfz6y4.web.app

(expires Wed, 28 Aug 2024 12:05:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ac0a9c931657844a433a502135cf38aca21627

@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 29, 2024 12:06
@HalcyonJAC HalcyonJAC requested review from a team as code owners July 29, 2024 12:06
@nickaddy
Copy link
Contributor

@HalcyonJAC The Save and continue button is greyed out for me irrespective of whether or not the NINo field is populated.

@HalcyonJAC
Copy link
Contributor Author

@nickaddy It might be that you have submitted the application. I have moved your application to draft for this exercise. Could you test it again, please?

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works, @HalcyonJAC, thank you :-)

Copy link

@Franceswog Franceswog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NI field is mandatory, no issues to report.

@HalcyonJAC HalcyonJAC merged commit 793ade0 into main Jul 30, 2024
7 checks passed
@HalcyonJAC HalcyonJAC deleted the feature/1204-mandate-nino-field-in-personal-details-section-of-application-form branch July 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandate NINo field in Personal details section of Application form
5 participants