Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ being stripped from emails in IA links #28

Closed
crablab opened this issue Jul 16, 2020 · 4 comments
Closed

+ being stripped from emails in IA links #28

crablab opened this issue Jul 16, 2020 · 4 comments
Assignees
@warrensearle
Labels
assessments: 0.6.0 bug Something isn't working

Comments

@crablab
Copy link
Contributor

crablab commented Jul 16, 2020

Issue: the + symbol is being stripped from email addresses at some point between the link being clicked on in the IA email, and the email being sent to the backend. This causes an unhandled exception.
image.png

Expected: emails with a + in them are valid. We should fix this.
@crablab crablab added the bug Something isn't working label Jul 16, 2020
@warrensearle warrensearle added bug Something isn't working and removed bug Something isn't working labels Jul 21, 2020
@warrensearle
Copy link
Member

Hey @crablab this looks like a UI issue. Please could you investigate and let me know.

@warrensearle
Copy link
Member

Actually think this might be solved in the back-end by encoding the email address using encodeUriComponent()... but be good to know if there's a UI-based fix too

@crablab
Copy link
Contributor Author

crablab commented Jul 28, 2020

As discussed, backend bug in emails. @warrensearle to look at in Digital Platform 😄

@warrensearle warrensearle self-assigned this Jul 29, 2020
warrensearle added a commit that referenced this issue Jul 29, 2020
@warrensearle
#28 + being stripped from emails in IA links
899945a 
Quick fix. Replace spaces in received email address with plus
@warrensearle
Copy link
Member

Will look at this in the digital platform however in the meantime I've applied a very quick fix to the UI which does the job.

YaaL added a commit that referenced this issue Jul 30, 2020
@YaaL
Merge pull request #50 from jac-uk/feature/28-plus-being-replaced-wit…
104297c 
…h-space

#28 `+` being stripped from emails in IA links
YaaL added a commit that referenced this issue Jul 31, 2020
@YaaL
Merge tag '0.6.0' into develop
5934c15 
 #28`+` being stripped from emails in IA links
 #29 Directly accessing `/assessments/{id}/upload` with different login has incorrect error
 #30 Clicking on the `< back` button on /assessment/{id}/upload goes to sign in
 #48 Carries over FileUpload changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warrensearle warrensearle

Labels
assessments: 0.6.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@YaaL @crablab @warrensearle