Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to use cartographer_ros pkg instead of building from source #2

Merged
merged 8 commits into from Feb 7, 2020

Conversation

jazzalin
Copy link
Contributor

@jazzalin jazzalin commented Feb 4, 2020

Modifications made:

  • added cartographer_ros as run_depend
  • updated install instructions in README (could also be updated)
  • modified cartographer parameters to reflect latest parameter naming conventions

Tested with melodic

@tonybaltovski tonybaltovski changed the base branch from master to melodic-devel February 6, 2020 04:16
published_frame = "odom",
odom_frame = "odom",
provide_odom_frame = false,
publish_frame_projected_to_2d = false,
use_odometry = true,
use_odometry = false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you disabled the odometry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason really.. was testing it without and forgot to change it back. Both configs produced good results

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, thanks for adding this back in.

@tonybaltovski tonybaltovski merged commit 8617818 into jackal:melodic-devel Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants