Add implementation for Jackalope\Node::isNodeType()

jackalope · May 7, 2011 · a4c9451 · a4c9451
1 parent 2b059f9
commit a4c9451
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/src/Jackalope/Node.php b/src/Jackalope/Node.php
@@ -802,7 +802,10 @@ public function getMixinNodeTypes()
      */
     public function isNodeType($nodeTypeName)
     {
-        throw new NotImplementedException();
+        return (
+            $this->primaryType == $nodeTypeName ||
+            (isset($this->properties["jcr:mixinTypes"]) && in_array($nodeTypeName, $this->properties["jcr:mixinTypes"]->getNativeValue()))
+        );
     }
 
     /**

diff --git a/tests/Jackalope/NodeTest.php b/tests/Jackalope/NodeTest.php
@@ -6,21 +6,33 @@ class NodeTest extends TestCase
 {
     protected $JSON = '{":jcr:primaryType":"Name","jcr:primaryType":"rep:root","jcr:system":{},"tests_level1_access_base":{}}';
 
-    public function testConstructor()
+    protected function createNode()
     {
         $factory = new \Jackalope\Factory;
         $session = $this->getMock('Jackalope\Session', array(), array($factory), '', false);
         $objectManager = $this->getMock('Jackalope\ObjectManager', array(), array($factory), '', false);
         $node = new Node($factory, json_decode($this->JSON), '/jcr:node', $session, $objectManager);
-        $this->assertSame($session, $node->getSession());
+        return $node;
+    }
+
+    public function testConstructor()
+    {
+        $node = $this->createNode();
+        $this->assertType('Jackalope\Session', $node->getSession());
         $this->assertType('jackalope\Node', $node);
-        //TODO: Activate this…
-        // $this->assertTrue($node->getPrimaryNodeType()->isNodeType('rep:root'));
         $children = $node->getNodes();
         $this->assertType('Iterator', $children);
         $this->assertSame(2, count($children));
     }
 
+    public function testNodeType()
+    {
+        $node = $this->createNode();
+        $this->assertTrue($node->isNodeType('rep:root'), "Should return true on is 'rep:root' node type.");
+        //TODO: Activate this…
+        // $this->assertTrue($node->getPrimaryNodeType()->isNodeType('rep:root'));
+    }
+
     public function testFilterNames()
     {
         $filter = 'test';