Cleanup functional tests #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was my first idea. I extended the normal TestClient. So it would check for changed behaivior in the but as it would alter teststats strongly, i wasnt bold enought. ^^ But like you suggested it was my first idea aas well. If its ok ill "rredo" it and start from there. :) |
|
i am not sure if all tests in ClientTest make sense to redo, or if they even work. maybe have a look and if they do, extending ClientTest would sound good to me. otherwise split ClientTest into an abstract class BaseClientTest that holds the common test cases and a ClientTest | CachedClientTest with extra tests. i will just merge this here now, then you can start from master. feel free to refactor, we have pull requests to review things ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to improve the test coverage, please start from this branch @ARoddis
One idea i had was that CachedClientTest and ClientTest could share many of the tests, so that we usually test the behaviour with caching automatically as well and see if anything breaks.