Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate travis to github actions #165

Merged
merged 5 commits into from
Jan 24, 2021

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Jan 16, 2021

@alexander-schranz alexander-schranz force-pushed the feature/github-actions branch 3 times, most recently from 46d668c to aadcbf4 Compare January 16, 2021 18:36
@alexander-schranz alexander-schranz mentioned this pull request Jan 16, 2021
52 tasks
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. i think something with the matrix is odd here, and i think we lose the lowest version build.

can you please check the builds in your fork? it looks like the last version messed up something with jackrabbit - maybe it was a temporary hickup? as you seem to not have changed anything about how it gets installed...

.github/workflows/test-application.yaml Outdated Show resolved Hide resolved
- 7.4
- 8.0
dependencies:
- highest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be rewritten to the composer flag --prefer-lowest to be only used on the lowest php version instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think the combiniation between include and normal matrix is buggy in github action I moved all to the include now.

@dbu
Copy link
Member

dbu commented Jan 22, 2021

the last travis-ci build worked: https://travis-ci.com/github/jackalope/jackalope-jackrabbit/jobs/434093834

but that was 2 months ago. i now restarted it to see if the jackrabbit problem is with the changes here or with what we get when downloading

@dbu
Copy link
Member

dbu commented Jan 22, 2021

hm. still green. can you check how you install and start jackrabbit and how it was done before? looks like something has changed

@alexander-schranz
Copy link
Contributor Author

@dbu downgraded ubuntu now its running again. could not find out why it is not working with ubuntu 20 🙈

@dbu
Copy link
Member

dbu commented Jan 24, 2021

thanks! weird, no idea why that is. but as long as the tests run, i am happy. lets hope ubuntu 18 stays available for a while still...

@dbu dbu merged commit efa6df1 into jackalope:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants