-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate travis to github actions #165
Migrate travis to github actions #165
Conversation
46d668c
to
aadcbf4
Compare
aadcbf4
to
394acf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. i think something with the matrix is odd here, and i think we lose the lowest version build.
can you please check the builds in your fork? it looks like the last version messed up something with jackrabbit - maybe it was a temporary hickup? as you seem to not have changed anything about how it gets installed...
- 7.4 | ||
- 8.0 | ||
dependencies: | ||
- highest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should be rewritten to the composer flag --prefer-lowest to be only used on the lowest php version instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think the combiniation between include and normal matrix is buggy in github action I moved all to the include now.
the last travis-ci build worked: https://travis-ci.com/github/jackalope/jackalope-jackrabbit/jobs/434093834 but that was 2 months ago. i now restarted it to see if the jackrabbit problem is with the changes here or with what we get when downloading |
hm. still green. can you check how you install and start jackrabbit and how it was done before? looks like something has changed |
279b7be
to
4b49f81
Compare
thanks! weird, no idea why that is. but as long as the tests run, i am happy. lets hope ubuntu 18 stays available for a while still... |
See CI in alexander-schranz#1