test out of range strings #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dbu |
|
we might be able to relax some of the checks eventually .. |
| @@ -1197,6 +1198,13 @@ private function storeProperty(Property $property) | |||
| $path = $property->getPath(); | |||
| $typeid = $property->getType(); | |||
| $nativeValue = $property->getValueForStorage(); | |||
| if ($typeid === PropertyType::STRING) { | |||
| foreach ((array) $nativeValue as $string) { | |||
There was a problem hiding this comment.
are you dead sure that this is under no circumstances a regression? like if i pass in some object that can do foreach? or do we have a similar construct elsewhere already?
There was a problem hiding this comment.
|
apart from this, thanks for fixing. sad that we need to limit those, but rather limit until we figure out properly how to handle those character ranges. can you please open a follow-up issue to maybe fix this at some point? |
|
thanks lukas. things are really getting ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent #53