Jack2 latent_client.c #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example-clients/latent_client.c: Remove latent_client.c as the jack2 version of the file has been applied already with changes applied. This makes a clean rebase on top of the orginal version not possible.
26 tasks
added 4 commits
December 13, 2021 20:47
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4153 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4155 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4252 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4610 0c269be4-1314-0410-8aa9-9f06e86f4224
dvzrv
force-pushed
the
jack2_latent_client
branch
from
107e31e
to
de90cc2
Compare
falkTX
reviewed
Dec 30, 2021
| @@ -21,30 +21,36 @@ jack_default_audio_sample_t *delay_line; | |||
| jack_nframes_t delay_index; | |||
| jack_nframes_t latency = 1024; | |||
|
|
|||
| #ifdef WIN32 | |||
| #define jack_sleep(val) Sleep((val)) | |||
There was a problem hiding this comment.
this macro is only used once, so I dont really think it makes sense. plus the -1*1000 for !win32 case makes it be very weird..
will remove this part to be more in line with the other examples, which do not use a macro
There was a problem hiding this comment.
Should we add a ticket for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example-clients/latent_client.c:
Merge the jack2 version of latent_client.c as its initial version
diverted from the original example-clients.
Relates to #9