Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/cpu cleanup #58

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Conversation

jcowgill
Copy link
Contributor

@jcowgill jcowgill commented Dec 3, 2016

Fixes #56

It turns out all the cycles.h files are also unused, so I've removed those as well. The atomicity.h files could also be replaced with the generic implementation but I wasn't sure if that was kept for a reason (other platforms?)

@jdek
Copy link
Contributor

jdek commented Dec 3, 2016

Did you test the other platforms? (Do they still work?)

@jcowgill
Copy link
Contributor Author

jcowgill commented Dec 3, 2016

No, I haven't. I simply removed the files based on them never being included anywhere else in the jack codebase. In theory this PR has absolutely no effect on any platform.

@adiknoth adiknoth self-assigned this Jan 9, 2017
@adiknoth adiknoth self-requested a review January 9, 2017 23:52
Copy link
Member

@adiknoth adiknoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this stuff is really unused.

@adiknoth adiknoth merged commit d355c7d into jackaudio:master Jan 9, 2017
@adiknoth
Copy link
Member

@jcowgill I think we should replace the atomicity.h files with the generic one - pretty much everyone should be using the compiler builtins by now.

If you want to send another PR, I'm happy to merge.

Thanks

@jcowgill
Copy link
Contributor Author

@adiknoth OK I can send another PR. Does jack have a minimum GCC version? I ask because the __sync functions are deprecated and should be replaced if possible. For GCC, __sync* requires 4.1, __atomic* requires 4.7, and C11's stdatomic.h requires 4.9.

@adiknoth
Copy link
Member

adiknoth commented Jan 10, 2017

Let's use C11 if available or 4.7 if not. GCC 4.9 was released in April 2014, that's almost three years, 4.7 in March 2012, almost five years.

According to wikipedia: "A standard macro __STDC_VERSION__ is defined with value 201112L to indicate that C11 support is available."

So we can have something like

#if __STDC_VERSION__ >= 201112L #include <stdatomic.h> ... #else ... #fi

Thanks!

@jcowgill jcowgill mentioned this pull request Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants