-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD support #400
Add FreeBSD support #400
Conversation
|
||
namespace Jack | ||
{ | ||
struct JackRequest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab
struct JackRequest; | ||
struct JackResult; | ||
|
||
class JackPosixMutex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab
|
||
static inline char CAS(volatile UInt32 value, UInt32 newvalue, volatile void* addr) | ||
{ | ||
return atomic_cmpset_32((uint32_t*)addr, value, newvalue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab
This PR looks good to me, I think we should probably merge it away. Are there any opinions from other FreeBSD users? If possible please also attach a full verbose build log. |
@@ -0,0 +1 @@ | |||
../linux/driver.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to figure out something better for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. Is this about naming, licenses and such or about technical shortcomings?
@myfreeweb Could you please squash all commits into one? |
Difficult to add 6 lines, need to maintain the proper order of patches, etc. Also, |
If you want to test in ports, you can just fetch from my branch. If you want to commit a port already… isn't it a bit early? :) |
From
This hints at that O_RDWR is correct. From
Like shared memory handles for shm_open, semaphores should start with a slash. I think this rule isn't strictly enforced, any name without slashes in the middle should work. I speculate that using a leading slash wouldn't be problematic on any platform. However there are different semaphore name length limits on different platforms (see OSX max. client name length). |
8657c6d
to
aec2c2d
Compare
@falkTX Could you please elaborate on your review above ( If it's about using symlinks, there's the option of a relay Otherwise, it's probably also acceptable to drop the ALSA backend on FreeBSD, which refers to FYI, jack2 v1.9.16 is now in the FreeBSD ports, taken from a branch in my repo. It is based on these commits plus a separate, overhauled OSS driver taylored to FreeBSD. I intend to make an up-to-date pull request for that, thus my interest in how to fix this. |
FYI: Jack2 is now available in FreeBSD ports: https://www.freshports.org/audio/jack/ |
Closing this, superseded by #800 which includes most of the work in this pull request. |
(re: #283)
umtx
(futex
equivalent)O_RDWR
in semaphores?/
?-fPIC
to build the OSS adapter, I'm not sure where in waf I should enable PIC