Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple of missing headers in macosx sources #951

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

barracuda156
Copy link

It was forgotten for this one.

@barracuda156 barracuda156 marked this pull request as draft July 30, 2023 09:51
@barracuda156
Copy link
Author

barracuda156 commented Jul 30, 2023

Converted to draft, because another header is missing in other source file. Will update soon.

P. S. <algorithm> is needed for std::find.

@barracuda156 barracuda156 marked this pull request as ready for review July 30, 2023 10:03
@barracuda156 barracuda156 changed the title JackCoreMidiOutputPort.mm: add missing memory include Add a couple of missing headers in macosx sources Jul 30, 2023
@barracuda156
Copy link
Author

@falkTX Could you please review? Regardless of ICE with GCC which hopefully gonna be fixed (and relevant only for 32-bit), these are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant