Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements with aria-hidden should not have focusable descendants #100

Conversation

jackdomleo7
Copy link
Owner

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Link(s)

Screenshot(s)

image

Checklist:

  • I have thoroughly read the CONTRIBUTING guidelines.
  • I understand my pull request will be thoroughly reviewed at high detail.
  • I understand the work in my pull request will only be available in the next version release of Checka11y.css and not in the current version release.
  • I confirm the work in this pull request is valid according to my findings and is not something for anything personal.
  • I have updated the README and/or features.md where and if applicable (still put an x if you have considered this but thought there was nothing to add or modify).
  • I have added myself to the contributors section in package.json (still put an x if you have considered this but decided not to add yourself).
  • I have checked I have not committed any accidental files.
  • I have tested all the main modern browsers (I.e. Chrome, Firefox, Edge, Safari - please leave this unchecked if there were any browsers listed you could not test and list them in the help section with details why you couldn't test that browser)
  • I have run the automated tests and added new ones to cover new code.
  • All new and existing a11y checks still work correctly (compare your local test/index.html to the test/index.html in the master branch).

Help

N/A

@jackdomleo7 jackdomleo7 added the a11y feature New feature or request for an a11y check label Feb 2, 2021
@jackdomleo7 jackdomleo7 self-assigned this Feb 2, 2021
@jackdomleo7 jackdomleo7 merged commit ae3410a into master Feb 2, 2021
@jackdomleo7 jackdomleo7 deleted the master__warning_for_aria-hidden_elements_that_contain_focusable_descendants branch February 2, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y feature New feature or request for an a11y check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning when [aria-hidden="true"] elements contain focusable descendants
1 participant