-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add define-struct-lenses and struct/lens #111
Conversation
The Travis CI build is failing because the package server hasn't updated yet after a new feature in the |
d4e0a9f
to
74e3b13
Compare
Ok the package server updated and I added more tests, rebased, and pushed, and now the build is passing. |
#'(begin | ||
(define-struct-updaters s) | ||
(define s-fld-lens (make-lens s-fld s-fld-set)) | ||
...)])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can some of this functionality be broken up into one or more helper macros to simplify the implementation?
add define-struct-lenses and struct/lens
Huh. Why is the travis build failing on the main repo now? It was working fine on the PR build, and it works fine for me. |
Not sure, some sort of complaint about the foo-a-lens. Rebuilding just to verify it wasn't a one-off. |
It's complaining about |
Actually, it seems like the error is coming from the other |
Oh. Is Travis by any chance getting the old version of the
|
That's definitely the problem, as I can install this locally on my machine with no trouble. I wonder why it's getting the old version? |
I looked on the package server to see if it was up to date, but I found that I wonder though: Why did Travis get the up-to-date version when it was building this pull request? |
There've been some commits today, that's all I can think of that's changed since this was last built and now. |
I don't think that's it. It's complaining about this missing module, and that wouldn't happen unless it was getting the old version of |
Travis should probably be upgraded to build with 6.2 anyway. Or maybe it should build with a proper build matrix and use both 6.2 and 6.1.1 |
Yup it's definitely the version exception. #119 builds on 6.2 in Travis but not 6.1.1 |
@jackfirth @AlexKnauth Yep, looks like I broke |
No trouble, builds installing fine now. Thanks for the quick fix @lexi-lambda |
No description provided.