Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Adding missing functions #31

Closed
wants to merge 33 commits into from
Closed

Conversation

Rafi993
Copy link

@Rafi993 Rafi993 commented Feb 27, 2018

List of functions added times, adjust, uniq, zip_with, zip_obj, xprod, without, update, identity, drop_last, empty, join

@Rafi993 Rafi993 changed the title times function added Adding missing functions Feb 27, 2018
@jackfirth
Copy link
Owner

Hello @Rafi993, nice to meet you! Thanks for taking interest in Pyramda and writing this pull request.

Fair warning: I don't have bandwidth to work on Pyramda at the moment and that's unlikely to change anytime soon. If you're interested in contributing more I'm happy to help with that, but I won't be working on features myself or devoting a lot of time to maintenance tasks. As for the PR, I have a few comments:

  • The Travis CI failure seems to be from code style warnings, please fix those.
  • Unit tests are missing. Existing code files in pyramda each have a corresponding _test.py file, and tests are written in plain functions instead of in classes and methods.
  • I'd like the README to be updated with type signatures of the new functions.

@coveralls
Copy link

coveralls commented Feb 27, 2018

Coverage Status

Coverage increased (+0.3%) to 95.511% when pulling af16c2a on Rafi993:master into 85ab1c2 on jackfirth:master.

@Rafi993
Copy link
Author

Rafi993 commented Mar 27, 2018

Since this repo seems to be unmaintained I am closing this pull request and host the future changes in the fork. Thanks for the awesome idea you have built

@Rafi993 Rafi993 closed this Mar 27, 2018
@jackfirth
Copy link
Owner

I'm happy to work with you to merge these changes @Rafi993. Are you intending to push more commits to this PR?

@Rafi993
Copy link
Author

Rafi993 commented Mar 28, 2018

Yes @jackfirth I do intend to push more commits to the repo so that most of the missing function is covered and I was looking into ways to make currying faster something like this http://code.activestate.com/recipes/229472-high-performance-currying-with-instancemethod/ . and to add benchmarks for each functions. And then to clean up the Readme.md and to have these docs searchable in a separate gitpage.

@Rafi993
Copy link
Author

Rafi993 commented Apr 1, 2018

@jackfirth I'll reopen the pull request and fix errors in my last commit

@Rafi993 Rafi993 reopened this Apr 1, 2018
@Rafi993 Rafi993 closed this Jul 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants