Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with API errors #91

Merged
merged 7 commits into from
Jun 22, 2014
Merged

Deal with API errors #91

merged 7 commits into from
Jun 22, 2014

Conversation

jackfranklin
Copy link
Owner

  • updated middleman to pass errors back
  • more consistently use cb(err, data) convention
  • deal with 503 errors (Heroku down)

@jackfranklin
Deal with API errors
b4b04dc 
* updated middleman to pass errors back
* more consistently use cb(err, data) convention
* deal with 503 errors (Heroku down)
@jackfranklin
Copy link
Owner Author

@PhUU

@jackfranklin jackfranklin mentioned this pull request May 29, 2014
Closed
@jackfranklin
Copy link
Owner Author

Eurgh, this isn't building because some modules we depend on have dependencies that use the new ^0.2.0 syntax, which Node 0.8 doesn't like. Time to ditch 0.8 support?

@jackfranklin
Copy link
Owner Author

@PhUU thoughts on above?

@jackfranklin
Copy link
Owner Author

I'm confused why this branch fails, because there are none of the ^ dependencies in the package.json.

@jackfranklin
Copy link
Owner Author

So one of our dependencies has a ^ hidden in it somewhere:

npm ERR! Error: No compatible version found: minimatch@'^0.3.0'
npm ERR! Valid install targets:
npm ERR! ["0.0.1","0.0.2","0.0.4","0.0.5","0.1.1","0.1.2","0.1.3","0.1.4","0.1.5","0.2.0","0.2.2","0.2.3","0.2.4","0.2.5","0.2.6","0.2.7","0.2.8","0.2.9","0.2.10","0.2.11","0.2.12","0.2.13","0.2.14","0.3.0"]
npm ERR!     at installTargetsError (/home/travis/.nvm/v0.8.26/lib/node_modules/npm/lib/cache.js:719:10)
npm ERR!     at /home/travis/.nvm/v0.8.26/lib/node_modules/npm/lib/cache.js:641:10
npm ERR!     at RegClient.get_ (/home/travis/.nvm/v0.8.26/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:101:14)
npm ERR!     at RegClient.<anonymous> (/home/travis/.nvm/v0.8.26/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:37:12)
npm ERR!     at fs.readFile (fs.js:176:14)
npm ERR!     at Object.oncomplete (fs.js:297:15)
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR!     <npm-@googlegroups.com>
npm ERR! System Linux 2.6.32-042stab079.5
npm ERR! command "/home/travis/.nvm/v0.8.26/bin/node" "/home/travis/.nvm/v0.8.26/bin/npm" "install"
npm ERR! cwd /home/travis/build/jackfranklin/pulldown
npm ERR! node -v v0.8.26
npm ERR! npm -v 1.2.30

I hate this.

Not going to merge this because doing so drops 0.8 which seems silly. @PhUU any pointers welcome. Screw dependencies.

@lloydwatkin
Copy link
Contributor

If running via travis then a simple:

before_install:
  - npm i -g npm

Will fix this for you :)

@lloydwatkin
Copy link
Contributor

#93

@jackfranklin
Copy link
Owner Author

@lloydwatkin you might just be my hero.

jackfranklin added a commit that referenced this pull request Jun 22, 2014
@jackfranklin
Merge pull request #91 from jackfranklin/deal-with-api-down
e7b910a 
Deal with API errors
@jackfranklin jackfranklin merged commit e7b910a into master Jun 22, 2014
@jackfranklin jackfranklin deleted the deal-with-api-down branch June 22, 2014 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackfranklin @lloydwatkin