Change overflow to scroll only if styleHeight is bigger then the actu… #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alHeight instead of not equal to. Fix: show scroll bar when not needed: min-height set to value bigger then height.
|
This seems fine, but I'm not aware of a situation in which this change affects the outcome. In the situation of your use case, autosize sets a style height based on the computed size which accounts for min-height style / rows (i.e., the real size). |
jackmoore
added a commit
that referenced
this pull request
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overflow to scroll only if styleHeight is bigger then the actualHeight instead of not equal to. Fixes: show scroll bar when not needed.
use case: min-height set to value bigger then height.