Bug fix if destroy is called before image onload has finished. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… onload during destroy. If destroy was called before the image onload was triggered, the onload function was still executed and appended the image to the page despite being destroyed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If destroy was called before the image onload was triggered, the onload function was still executed and appended the image to the page despite being destroyed.
This could cause many instances of the 'zoom' image to be appended undesirably, for example when initiating zoom on mouseover of thumbnails and destroying on mouseout. If a user drags mouse across thumbnails, all zoom images would be appended to the page despite destroy being called on mouseout prior to the image loading.