Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should dumb-jump use (thing-at-point 'sexp) instead of (thing-at-point 'symbol) ? #179

Open
ahungry opened this issue Nov 30, 2017 · 2 comments

Comments

@ahungry
Copy link

ahungry commented Nov 30, 2017

Some very rough preliminary testing shows them to return the same results in a few different file types that I've checked, however in Common Lisp, this is a valid function call/name for a function titled #/something:

(#/something "here")

If the cursor is on the #, it won't find a valid symbol, while it will find the match if using the sexp type (I assume the sexp is just grabbing until the first whitespace.

Granted, this is quite unusual, especially considering CL uses the sharpsign as a way to reference functions like #'symbol-name as well.

Thoughts?

@jacktasia
Copy link
Owner

Thanks for opening this! You're definitely on to something and this may be the proper solution for the likes of #168 and #174 (vs what I actually did). I thought I had started with sexp then moved over to using symbol (for a reason I can't remember) but after a very quick look I can't find evidence of this.

I am definitely going to look closer into this tonight or this weekend and report back. Thanks again for opening this!

@ahungry
Copy link
Author

ahungry commented Nov 30, 2017

Thank you for a wonderful package and prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants