Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Fsharp support #235

Merged
merged 3 commits into from
Oct 19, 2018
Merged

Added Fsharp support #235

merged 3 commits into from
Oct 19, 2018

Conversation

walseb
Copy link
Contributor

@walseb walseb commented Oct 19, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.063% when pulling c368db1 on walseb:master into b9692be on jacktasia:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.063% when pulling c368db1 on walseb:master into b9692be on jacktasia:master.

@coveralls
Copy link

coveralls commented Oct 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.063% when pulling 9c3418a on walseb:master into b9692be on jacktasia:master.

@jacktasia jacktasia self-requested a review October 19, 2018 22:34
@jacktasia
Copy link
Owner

Thanks for the PR! It looks like the rg tests are failing. If you don't want to fix them for rg it's totally fine to just drop rg from the :supports block. Thanks again!

@walseb
Copy link
Contributor Author

walseb commented Oct 19, 2018

That's really weird because rg --type-list returns fsharp: *.fs, *.fsi, *.fsx.
Anyway, I'm removing support for it like you suggested.

@walseb walseb changed the title Added Fsharp support Added Fsharp support for fsharp Oct 19, 2018
@walseb walseb changed the title Added Fsharp support for fsharp Added Fsharp support Oct 19, 2018
@walseb
Copy link
Contributor Author

walseb commented Oct 19, 2018

Oh yeah, the problem could also be that rg has some special regex rule. Anyway rg support isn't that important to me.

@walseb
Copy link
Contributor Author

walseb commented Oct 19, 2018

Oh, I forgot to remove some other rg support flags, fixing

jacktasia
jacktasia approved these changes Oct 19, 2018
View reviewed changes
Copy link
Owner

@jacktasia jacktasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jacktasia jacktasia merged commit e7a21fd into jacktasia:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacktasia jacktasia jacktasia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walseb @coveralls @jacktasia