Exposing buffer strategy option #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we still doing this giving the issues with loss concealment? |
|
@nwang92 @mattahorton I'd like to resurrect this for the next release. Now that the interface has multiple settings panes, I think this would best belong under a new "Advanced" one. Other things that should probably move there are "Update Channel" and possibly "Display Mode." |
nwang92
force-pushed
the
feature/vs-buffer-strategy
branch
3 times, most recently
from
aa65a81
to
3f033e6
Compare
nwang92
force-pushed
the
feature/vs-buffer-strategy
branch
from
3f033e6
to
fd6139a
Compare
|
Updated so it looks like this now: |
mikedickey
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we finalized the UX for this, but this PR should contain all the necessary backend work + a basic selector to control buffer strategy. If there's any follow up on visual changes we can do that iteratively?