feat: ability to hide tags in the recent notes component #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
approved these changes
May 20, 2024
| @@ -7,10 +7,18 @@ Quartz can generate a list of recent notes based on some filtering and sorting c | |||
|
|
|||
| ## Customization | |||
|
|
|||
| - Changing the title from "Recent notes": pass in an additional parameter to `Component.RecentNotes({ title: "Recent writing" })` | |||
There was a problem hiding this comment.
can we keep this as a bullet list to make it consistent with other documentation pages?
There was a problem hiding this comment.
can totally do, do you prefer me to keep the bullet list on this one, or should I make a table everywhere else?
There was a problem hiding this comment.
let's keep the bullet list for now :)
| </ul> | ||
| {opts.showTags && ( | ||
| <ul class="tags"> | ||
| {tags.map((tag) => ( |
There was a problem hiding this comment.
how does the spacing look with the tags removed?
There was a problem hiding this comment.
i just added some screen caps to the pull request
jackyzha0
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1068 by adding a simple
showTagsoption to the Recent Notes component which defaults to truehere is how tags look with tags enabled
And here with the
showTags: falseoption