Don't name anonymous enums

[joakim-noah]

D allows them, so I had to search-and-replace to get the Anonymous_x names out.

[jacob-carlborg]

Do you have an example of C code causing this problem?

[joakim-noah]

Try any anonymous enum with multiple elements. For example, the following is taken from a header I was translating:

enum {
ASENSOR_TYPE_ACCELEROMETER      = 1,
ASENSOR_TYPE_MAGNETIC_FIELD     = 2,
ASENSOR_TYPE_GYROSCOPE          = 4,
ASENSOR_TYPE_LIGHT              = 5,
ASENSOR_TYPE_PROXIMITY          = 8
};

It got translated to this:

extern (C):
enum _Anonymous_0
{
    ASENSOR_TYPE_ACCELEROMETER = 1,
    ASENSOR_TYPE_MAGNETIC_FIELD = 2,
    ASENSOR_TYPE_GYROSCOPE = 4,
    ASENSOR_TYPE_LIGHT = 5,
    ASENSOR_TYPE_PROXIMITY = 8
}

Nobody's going to want to write _Anonymous_0.ASENSOR_TYPE_ACCEROMETER all over their code.

[jacob-carlborg]

I'll see what I can do about it.

[ciechowoj]

There is some problem with translating a corner case. Consider following code:

enum {
    FOO,
    BAR,
} baz;

D doesn't allow such a construction, so the enum is required to have explicit name, on the other side the enum items are still visible in global space. The best thing I can think of at the moment is to declare baz as int.

[ciechowoj]

The best solution would be to name the enum and still export its items to the global scope.

[jacob-carlborg]

Yeah, just through an alias.

[ciechowoj]

Could you provide an example ?

[ciechowoj]

Do you mean to repeat all the enumeration items as the aliases in global scope?

[jacob-carlborg]

enum  _Anonymous_0
{
    FOO,
    BAR
}

alias FOO = _Anonymous_0.FOO;
alias BAR = _Anonymous_0.BAR;

[ciechowoj]

Well, this can be done.