Fix guest logins #502
Merged
Fix guest logins #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to before attempted badges fix
|
👍 Looks good, sorry for my slowness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just reverted the guest login procedure to what it was before I attempted to fix the Kong badges.
Also, I added a line to
process_register_login()in the socket server code that checks if the guest is online already. If so, it won't disconnect the guest that's online but it'll disconnect the person logging in. This way, people who know the guest password won't be able to troll others who are just visiting.Edit: I also added a check for a direct guest account login in login.php.