Convert warnings to mutes #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes I'd rather just put a @ in front of a variable than rework an entire block of code.
Removes the existing kick (if one is already applied) before applying the new one.
Small fix to the urlify function so links and display text that involve the &jacob-grahn#39; character (apos) will be escaped properly. I'm proclaiming this "the ENT_QUOTES band-aid." This will need to be corrected throughout the rest of the repo, so once these few pending pulls of mine are merged, I'll get started on it (would be too many merge conflicts if I started now).
|
Travis Status for this branch (idk why it isn't showing on its own): |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull separates chat bans from the player object in favor of a server-logging system (like how kicking works). The difference will be negligible to a normal player, but this will allow us to do a lot more with chat bans than before, as well as abolishing warn evading by logging out and back into an account with an active warning.
In the future, with regards to mutes/warnings, I hope to:
fns/client/moderation.php)Player.phpThis also fixes a bug with kicking where if a user attempts to log in using a different case as was previously used (i.e. JIGGMIN instead of Jiggmin), the kick doesn't have any effect.