New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the links clickable in ban popup #520
Conversation
Good pull! For future reference @BrokenBulb78:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second review, the function urlify isn't present in the http server functions. Therefore, this change would throw an error.
The reason urlify exists is 1) so that consecutive links in the multiplayer server don't make the code 5 million lines long and 2) to escape backticks very easily if need be. There's no need in the http server because there's barely any places where either of those things would be needed.
I would just write plain HTML for your link. Just make sure you use target="_blank"
in your <a>
HTML tag.
Fixed! Thanks... And about the missing protocol, I noticed that when I made the pull so I immediately fixed it. 😂 |
👍 |
No description provided.