New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak campaign prizes, vault, fah #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bls1999
changed the title
[Quick Merge] Unbreak Campaign
[Quick Merge] Unbreak Campaign Prizes
Feb 6, 2019
Stxtics
approved these changes
Feb 6, 2019
bls1999
changed the title
[Quick Merge] Unbreak Campaign Prizes
[Quick Merge] Unbreak campaign prizes, vault
Feb 6, 2019
doesn't need to be performed every minute
bls1999
changed the title
[Quick Merge] Unbreak campaign prizes, vault
[Quick Merge] Unbreak campaign prizes, vault, fah
Feb 7, 2019
EternalUF
approved these changes
Feb 7, 2019
Already disabled in login.php, this just disables it here
EternalUF
approved these changes
Feb 9, 2019
for next Christmas
EternalUF
approved these changes
Feb 13, 2019
fixing depreciated table name
update allowed client version
EternalUF
approved these changes
Feb 15, 2019
bls1999
changed the title
[Quick Merge] Unbreak campaign prizes, vault, fah
Unbreak campaign prizes, vault, fah
Feb 15, 2019
Wooo, hopefully, this fixes alllll of the bugs @jacob-grahn :p |
EternalUF
approved these changes
Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query in the CRON was breaking campaign prizes updates, so I fixed it and made it update hourly instead of every minute (the campaign will never be changing that frequently). Additionally, admins can now manually update the campaign prizes with
/debug campaign refresh
, so there's no need for this.Things that should also be quick:
Things that won't be as quick but need to be fixed:
Wishful thinking: