Improvements to private server purchasing/expiration #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expire time now on popup - Starts a new server - Updates expire time on an existing server (in memory on socket) - Better error handling for status code 0
- Add global is_ps variable - Change uptime to timestamp after server init (in log) - Debug command optimizations
- Always send the command to extend the server life, not just in status code 2 (just in case the code failed somewhere and the server is actually active) - Only update socket-side if the new time is greater than the current expiration time - Automatically shut down and deactivate a server when the expiration time is hit - Deactivating a server changes the status to "down" instead of "offline", which seems to have been the root of the problem of private servers not reactivating properly when present in the db but previously expired and deactivated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull delivers some
MUCH NEEDED
stability fixes for private server purchasing, extending, and expiration procedures. This should fix most of the problems users were having with these features. Extended comments regarding all changes found on each commit.
(this one's for you, Alpha 馃槃)