Update to StrToId in Parts.php #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the jump_start element to the start of the jumpstart hat's array and the top_hat element to the start of the top hat's array (this was because I was originally going to set the id with the 1st element of the array as upper case but then I realised I could just do it with the last element) - Put all the arrays in 1 big array - Made a foreach loop that goes through the array that checks whether the string is in each of the sub-arrays - If it's in the sub-array, then the id is the last element of the sub-array It didn't say anything was wrong in code checker for both versions 7.3 and 5.6 but I've never used php before so there's a good chance that something here is wrong
|
I'll review this tonight |
Tidy up strToID in Parts.php -- Northadox's pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't say anything was wrong in code checker for both versions 7.3 and 5.6 but I've never used php before so there's a good chance that something here is wrong
EDIT: IdToStr too