Adds tests around isReply, breaks up getDescription a bit

jacobemerick · Nov 11, 2017 · 7cfe9f6 · 7cfe9f6
1 parent f4a532b
commit 7cfe9f6
Show file tree

Hide file tree

Showing 2 changed files with 94 additions and 14 deletions.
diff --git a/src/Cron/Process/Twitter.php b/src/Cron/Process/Twitter.php
@@ -183,17 +183,7 @@ protected function checkMetadataUpdated(array $event, stdclass $metadata)
     protected function getDescription(stdclass $metadata)
     {
         $message = $metadata->text;
-
-        $entities = [];
-        if (isset($metadata->entities->urls)) {
-            $entities += $metadata->entities->urls;
-        }
-        if (isset($metadata->entities->media)) {
-            $entities += $metadata->entities->media;
-        }
-        usort($entities, function ($a, $b) {
-            return $a->indices[0] < $b->indices[0];
-        });
+        $entities = $this->getEntities($metadata->entities, [ 'media', 'urls' ]);
 
         array_walk($entities, function ($entity) use (&$message) {
             $message = (
@@ -213,6 +203,27 @@ protected function getDescription(stdclass $metadata)
         );
     }
 
+    /**
+     * @param stdclass $tweetEntities
+     * @param array $entityTypes
+     * @return array
+     */
+    protected function getEntities(stdclass $tweetEntities, array $entityTypes)
+    {
+        $entities = [];
+        array_walk($entityTypes, function ($entityType) use ($tweetEntities, &$entities) {
+            if (isset($tweetEntities->{$entityType})) {
+                $entities += $tweetEntities->{$entityType};
+            }
+        });
+
+        usort($entities, function ($entityA, $entityB) {
+            return $entityA->indices[0] < $entityB->indices[0];
+        });
+
+        return $entities;
+    }
+
     /**
      * @param stdclass $metadata
      * @return string

diff --git a/tests/unit/Cron/Process/TwitterTest.php b/tests/unit/Cron/Process/TwitterTest.php
@@ -1011,17 +1011,86 @@ public function testGetTweetMetadataFormatsMetadata()
 
     public function testIsTweetReplyReturnsTrueIfMetadataIsReply()
     {
-        $this->markTestIncomplete();
+        $metadata = [
+            'in_reply_to_user_id' => 123,
+            'text' => 'some text',
+        ];
+
+        $tweet = [
+            'metadata' => json_encode($metadata),
+        ];
+
+        $twitter = $this->getMockBuilder(Twitter::class)
+            ->disableOriginalConstructor()
+            ->setMethods()
+            ->getMock();
+
+        $reflectedTwitter = new ReflectionClass(Twitter::class);
+
+        $reflectedIsTweetReplyMethod = $reflectedTwitter->getMethod('isTweetReply');
+        $reflectedIsTweetReplyMethod->setAccessible(true);
+
+        $result = $reflectedIsTweetReplyMethod->invokeArgs($twitter, [
+            $tweet,
+        ]);
+
+        $this->assertTrue($result);
     }
 
     public function testIsTweetReplyReturnsTrueIfTextStartsWithSnail()
     {
-        $this->markTestIncomplete();
+        $metadata = [
+            'in_reply_to_user_id' => null,
+            'text' => '@user some text',
+        ];
+
+        $tweet = [
+            'metadata' => json_encode($metadata),
+        ];
+
+        $twitter = $this->getMockBuilder(Twitter::class)
+            ->disableOriginalConstructor()
+            ->setMethods()
+            ->getMock();
+
+        $reflectedTwitter = new ReflectionClass(Twitter::class);
+
+        $reflectedIsTweetReplyMethod = $reflectedTwitter->getMethod('isTweetReply');
+        $reflectedIsTweetReplyMethod->setAccessible(true);
+
+        $result = $reflectedIsTweetReplyMethod->invokeArgs($twitter, [
+            $tweet,
+        ]);
+
+        $this->assertTrue($result);
     }
 
     public function testIsTweetReplyReturnsFalseIfNotReply()
     {
-        $this->markTestIncomplete();
+        $metadata = [
+            'in_reply_to_user_id' => null,
+            'text' => 'some text',
+        ];
+
+        $tweet = [
+            'metadata' => json_encode($metadata),
+        ];
+
+        $twitter = $this->getMockBuilder(Twitter::class)
+            ->disableOriginalConstructor()
+            ->setMethods()
+            ->getMock();
+
+        $reflectedTwitter = new ReflectionClass(Twitter::class);
+
+        $reflectedIsTweetReplyMethod = $reflectedTwitter->getMethod('isTweetReply');
+        $reflectedIsTweetReplyMethod->setAccessible(true);
+
+        $result = $reflectedIsTweetReplyMethod->invokeArgs($twitter, [
+            $tweet,
+        ]);
+
+        $this->assertFalse($result);
     }
 
     public function testInsertTweetGetsDescription()