Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override Manufacturer and FriendlyName #20

Merged
merged 3 commits into from
Jun 6, 2017
Merged

Add ability to override Manufacturer and FriendlyName #20

merged 3 commits into from
Jun 6, 2017

Conversation

AshleyMedway
Copy link
Contributor

This was useful at least for what I needed to do.

Also fixed the documentation :)

Great project 👍

@eelcocramer
Copy link
Collaborator

Thank you for the PR!

Maybe you can add documentation on how to use the friendlyName & manufacterer?

@AshleyMedway
Copy link
Contributor Author

Sure shall I just update the example? There's no doc in the readme for custom devices, or did you want to start a wiki?

Additionally, some comments for each property.
@eelcocramer
Copy link
Collaborator

Great thanks a lot!

@eelcocramer eelcocramer merged commit 7b7c376 into jacobrask:master Jun 6, 2017
eelcocramer added a commit that referenced this pull request Jun 6, 2017
There are hanges to the API but remains backward compatible with version 0.1
See also #20
@eelcocramer
Copy link
Collaborator

Published to npm as version 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants