Fix sysmacros.h include for non-glibc libcs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobstanley if you have any better idea for a more generic fix, let me know, for now I think this should cover the cases better than previously. |
|
@q66 yeah I have no idea about a more generic fix, i'll move forward with this change and let's see what happens 🤔 |
|
Perfect, thank you; I don't think this should be much of a concern, in places where this worked before this should continue to work and where it didn't it needs to be handled on case by case basis... |
|
@q66 👍 also published for you https://hackage.haskell.org/package/unix-compat-0.5.2 thanks for the PR! |
|
Great, I'll look into bumping all affected software in the distro during tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago glibc stopped including this from
sys/types.hso this explicit include was added. Themusllibc has since followed suit and stopped including this header insys/types.h, therefore it's also necessary to do this.These
major/minormacros are not a part of POSIX or any other standard, therefore since we're already using them, it's probably safe to assume the same header will also be used.This fixes build of several haskell software for
muslin our distribution (@void-linux).Also, while at it, would it be possible to publish a new release with the fix ideally as soon as possible? That would make it a lot easier to fix the broken software in the distro (since it won't need manual patching of every single thing, just a simple version bump).
Thanks!