-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixing extra jvm arguments for the surefire-maven-plugin with jacoco #44
Comments
BTW, the agent Ant task works the same way: If it is not enabled it sets the property to the empty string: |
Hi, Not sure what the process is for having the patch reviewed and merged. Please let me know if you need further changes / info from me. |
@isavin Hi, first of all - thanks for your contribution, I'll review patch as soon as possible on this week, when I'll have free time and that's why it's assigned to me ;) |
Done in ca86383 |
execution was skipped
GitHub #44: (Regression) Agent Mojo should set empty property, if execution was skipped
@Controlix, you are right, there was a regression fixed with pull request |
Noticed that the maven jacoco plugin appends the agent to the argLine property of the surefire plugin. Since I need to add some additional parameters to the jvm cmdline I ended up using something similar to this
<argLine>-foobar ${argLine}</argLine>
in order to preserve the jacoco agent. All works OK if I don't disable the jacoco plugin using the skip property. If I do that I end up with an argLine property which is not initialized and because of that the actual string "${argLine}" is appended to the jvm command line.Is there a better way to handle extra surefire jvm arguments with the jacoco plugin?
The text was updated successfully, but these errors were encountered: