-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable silence call recording alerts
flags cause recording failed
#50
Comments
It seems that Google has changed something recently. This bug was not showing up in com.google.android.dialer_94.0.488803600-publicbeta_10681122. I'll look at it as soon as possible. Update: currently unsolvable. In latest versions, Google Dialer always tries to rewrite the alert audio with the original one. |
I'm curious if they are simply updating the files every time or if they check a hash of the file and overwrite if it doesn't match. Regardless, either way doesn't seem to be solvable from just a dummy file alone, that being said, it is possible to do, just would require more effort and probably not within the scope of this tool. It would be possible to do with something like revanced or frida, but that requires digging through obfuscated decompiled code to figure out where to hook in. |
Actually digging through their code it's not so difficult and patching could be done also with Xposed, but in that case it will be hooked to a specific version of the Dialer, because each time they compile a new apk, function names are randomized. However, this tool was just about phenotype.db and filesystem things (and it still could be improved, e.g. as of #51, because I know there are many amazing hidden features in other Google Apps as well). So I agree they may have beaten us about the recording announcements and, at this point, silencing them may be out of scope. |
Btw they are replacing files every time a recording is started without checking anything. It may even be a bug and not an intentional behaviour. |
IDK, I was digging through the code trying to find where to bypass the checks that trigger the failure and I wasn't making much progress, but then again, I'm not super experienced in decompiling and reverse engineering. As for the randomized function names, are you familiar with how revanced works? In theory their patches could work for multiple app versions because rather than looking at method names they check for a fingerprint (combination of strings, opcodes, return types, etc.) in order to find where to patch the bytecode. It's pretty cool. Definitely out of scope for this though. |
Would this issue still occur if we replaced the original files in the APK with the patched ones? |
For reference: latest Google Dialer version in which we can silence call recording announcement is https://www.apkmirror.com/apk/google-inc/google-phone/google-phone-94-0-490096008-release/. I'm going to release a new version of GoogleDialerMod that doesn't allow users to enable the "silence call recording" switch if they have installed Google Dialer > 94.x. A workaround to silence call recording alerts anyway could be to use TTSLexx. |
If you had enabled the "silence call recording alerts" mod and you can't disable it anymore because the switch is disabled in the new version of GoogleDialerMod, use the trash can icon at the right in the topbar to remove all mods and reset the Dialer to a working state, then reapply your desidered mods. |
Hi bud, call recordings used to work for me but have stopped for a while. I tried your above suggestion but still get "recording failed" when I push record button during a call. Also if I push the button again it doesn't attempt to stop recording but the button remains in an on/activated state and continue to receive "recording failed" messsage. My settings are below. Any ideas? Thanks
Edit: forgot to update Dialer version after copy/pasting, sorry! |
I've made an xposed module for anyone who wants to mute or customize sounds for versions after Dialer 94.x to check out: |
Thanks @D3it7i I'll give it a try. So, I'll install your release and then try enable GAppsMod |
If you don't place *_custom.wav or permissions are incorrect. Recording prompts will be muted. Just install my xposed module and enable it, and it will run according to the function designed by my module (custom or silent prompt). Nothing to do with gappsmod. If you use a higher version of Dialer, you should still turn off the option of |
I installed your module, deleted the wav files and still could hear the recording announcement. Am I missing something? |
@doomwithdon it's probably best to open a new issue on that project's tracker. That being said, if you delete the official |
use TTSLexx to silence call recording alerts, it work for me :-) |
Overview
When the
silence call recording alerts
flags is enabled, clicking the record button shows that the recording failed. If I turn off the flag ofsilence call recording alerts
, the call can be successfully recorded.recording failed settings:
recording success settings:
System Information
Device and model: motorola edge 20 pro
ROM and Android version: Android 12
Is Google Dialer installed as system app: yes
Installed Magisk / other SU Manager version: Magisk 25.2
Logcat
The text was updated successfully, but these errors were encountered: