jammit-s3 now uses the package_path parameter #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, sorry for the delay. i'm no longer using this gem. would you like to take it over? |
|
Hey, Yeah I actually had some further ideas for this. I'll take it over if you want to transfer ownership |
|
Is there any progress on this? |
|
I actually haven't had much time to update the gem any further than my latest pull. I had previously expressed interest in taking it over but I'm rethinking it due to time constraints. Sean, would you be interested? |
|
hey Sean, I can add you as project collab if you want to try to merge this in and release it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where we need to store assets for distribution on cloudfront. We wanted each environment to have its own route folder on the s3 bucket. Jammit-s3 was currently not using the package_path parameter but it seems logical that it should.