fixed issue #16 on firefox

jadjoubran · Aug 6, 2015 · cd0255d · cd0255d
1 parent b35b798
commit cd0255d
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 17 deletions.
diff --git a/angular/app/sidebar/sidebar.html b/angular/app/sidebar/sidebar.html
@@ -6,19 +6,19 @@ <h6 class="Sidebar-version">v 2.2.2</h6>
 		</md-toolbar>
 		<md-content class="Sidebar-pages md-default-theme">
 			<md-list>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.landing">Overview</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.install">Install</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.tabs">Features</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.deploy">Deploy</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.theme">Theme</div>
 				</md-list-item>
 			</md-list>

diff --git a/angular/app/sidebar/sidebar.js b/angular/app/sidebar/sidebar.js
@@ -3,9 +3,6 @@
 
 	angular.module('app.controllers').controller('SidebarCtrl', function($scope, $state){
 
-		$scope.noop = function(){
-			//noop hack to make the hover effect work
-		};
 
 	});
 

diff --git a/angular/app/sidebar/sidebar.less b/angular/app/sidebar/sidebar.less
@@ -26,6 +26,10 @@
 	background-color: rgba(158, 158, 158, 0.2) !important;
 }
 
+.Sidebar-page{
+	cursor: pointer;
+}
+
 .Sidebar-page div{
 	width: 100%;
 }

diff --git a/public/css/app.css b/public/css/app.css
@@ -55,6 +55,9 @@
 .Sidebar-pages md-list md-list-item button.md-button:not([disabled]):hover {
   background-color: rgba(158, 158, 158, 0.2) !important;
 }
+.Sidebar-page {
+  cursor: pointer;
+}
 .Sidebar-page div {
   width: 100%;
 }

diff --git a/public/js/app.js b/public/js/app.js
diff --git a/public/views/app/sidebar/sidebar.html b/public/views/app/sidebar/sidebar.html
@@ -6,19 +6,19 @@ <h6 class="Sidebar-version">v 2.2.2</h6>
 		</md-toolbar>
 		<md-content class="Sidebar-pages md-default-theme">
 			<md-list>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.landing">Overview</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.install">Install</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.tabs">Features</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.deploy">Deploy</div>
 				</md-list-item>
-				<md-list-item ng-click="noop()" ui-sref-active="active" class="Sidebar-page">
+				<md-list-item ui-sref-active="active" class="Sidebar-page" md-ink-ripple>
 					<div ui-sref="app.theme">Theme</div>
 				</md-list-item>
 			</md-list>