Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo site navigation not working. #16

Closed
Bodom78 opened this issue Aug 6, 2015 · 15 comments
Closed

Demo site navigation not working. #16

Bodom78 opened this issue Aug 6, 2015 · 15 comments

Comments

@Bodom78
Copy link
Collaborator

Bodom78 commented Aug 6, 2015

Noticed that clicking on the side menu items does not direct to the page.

I had to manually modify the address to see the other pages.

Firefox 39.0: Not working
IE 11: Not working
Chrome 44.x: Working

jadjoubran pushed a commit that referenced this issue Aug 6, 2015
@jadjoubran
Copy link
Owner

Hi @Bodom78
Thank you for the bug report!

It now works on Firefox
Can you let me know if it works on IE11? I only have Edge here and the developer tools emulation are not working

@Bodom78
Copy link
Collaborator Author

Bodom78 commented Aug 6, 2015

I can confirm that it's working in Firefox now.

IE11 menu now works but noticed a couple more issues.
The alert and toast buttons do not work.
Vertical alignment of menu items not centered.

Here is an image which shows the styling issue and the console error when clicking on the alert button.

ie11-errors

@jadjoubran
Copy link
Owner

Hmm it seems like an upstream issue (Angular Material) with IE11..
Can you visit the following and let me know if they work for you:

Toast: https://material.angularjs.org/latest/#/demo/material.components.toast
Dialog: https://material.angularjs.org/latest/#/demo/material.components.dialog
List: https://material.angularjs.org/latest/#/demo/material.components.list

@Bodom78
Copy link
Collaborator Author

Bodom78 commented Aug 6, 2015

Toast, Dialog and List demos all worked fine in IE11 on the Angular Material site with the 0.10.0 release.

@jadjoubran
Copy link
Owner

Okay, I'm looking into it!

@jadjoubran
Copy link
Owner

Since I have updated to Windows 10, it's impossible to install IE11 or even enable it in Developer Tools Emulation.

Would you be able to help me a bit on this? I have a few ideas in mind that I wanted to try.

  1. Can you try replacing

    with

    in sidebar.html inside md-list-item and see if it works on IE11?

  2. Can you try removing the "use strict"; from landing.js and check if toasts and dialogs work..

Thanks!

@Bodom78
Copy link
Collaborator Author

Bodom78 commented Aug 7, 2015

I'll have to try on Monday on my work PC.

On my laptop I've tried for about 5 hours to install the npm dependencies but they always fail with varying errors that I just cannot resolve.

@jadjoubran
Copy link
Owner

Okay thanks!

You can try clearing NPM's cache. This has worked several times for me when I was faced with random errors

@Bodom78
Copy link
Collaborator Author

Bodom78 commented Aug 8, 2015

Clearing the NPM cache was something I tried. It fixed the tar errors but now I have a heap of new ones that look like they are releated to the elixir npm dependencies.

What version of Node and NPM are you using? I will try the same on my machine.

@jadjoubran
Copy link
Owner

hmm I'm not sure if that would be related..

$ node -v
v0.12.2

$ npm -v
2.7.4

@Bodom78
Copy link
Collaborator Author

Bodom78 commented Aug 8, 2015

OK, I just set the site up on my wamp and worked on the already compiled files for the sake of testing.

Removing use strict from the landing module did not work. The error is actually coming from the vendor.js so I did a find and replace to remove all instances of it.

This did stop the error however the alert and toast buttons still no not work. No new errors show up.

What did you want replaced in sidebar.html?, the instructions in your post looks like it's missing from the first part.

@jadjoubran
Copy link
Owner

Hi @Bodom78, thanks a lot for helping on this issue. I'm going to create a new issue specifically for the sidebar and we'll keep this for the toast and dialog.js. I don't have an update on the toast and dialogs yet but I'm working on a new service for toasts and dialogs.

@jadjoubran
Copy link
Owner

So now everything is working on Firefox.. we still have the IE11 issue for taosts and dialogs

@jadjoubran
Copy link
Owner

It turned out to be an issue in Angular Material #3943

So this should work now.. Let me know!

@Bodom78
Copy link
Collaborator Author

Bodom78 commented Aug 13, 2015

Nice, I can confirm alerts and toasts are now working in IE11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants