Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth PWM Output #171

Merged
merged 2 commits into from
May 23, 2018
Merged

Smooth PWM Output #171

merged 2 commits into from
May 23, 2018

Conversation

vaishnavachath
Copy link
Contributor

I have tried to fix these issues related to PWM,

  • spikes occuring while writing zero duty cycle(proposed soln: disabled pwm while writing zero duty/freq)
  • smooth pwm output while sweping pwm frequency(proposed soln: suggested implementation alongside current implementation)
  • digitalWrite() on ANALOG_OUTPUT(proposed soln: write duty cycle according to value(0/1))

beagleboard#26
beagleboard#30
beagleboard#17

I have uploaded the test video here : https://youtu.be/_CiSsroef18

I couldn't figure out how to write test cases for these patches , that was why i included some non relevant tests,please excuse.

@coveralls
Copy link

coveralls commented May 22, 2018

Coverage Status

Coverage increased (+0.06%) to 37.111% when pulling e5b6489 on vaishnav98:master into 61d2fa2 on jadonk:master.

Copy link
Owner

@jadonk jadonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to figure out moving forward how to remove all synchronous reads and writes. For now, I think this is fine because the change will need to be wholesale.

Your video of the tests gives me the confidence to accept this code. Looks fairly clean and readable as well.

Thanks for the great work. This will make a number of people happy.

@jadonk jadonk merged commit ce7fd65 into jadonk:master May 23, 2018
@vaishnavachath
Copy link
Contributor Author

Glad to hear that :) , sure I will try to figure out a solution to the issue of removing sync read/write operations in future (didn't do it now for the patch since we need to make consistent changes everywhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants