Remove safari pinned tab favicon to fix HTML validation issue #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color attribute on the <link> tag isn’t valid and throws an error in the W3C validator. This has been an ongoing discussion with the validator team and the WhatWG (For over a year). See: * validator/validator#174 * whatwg/html#110 Until this is resolved I see no alternative but to remove the safari pinned tab icon, which is made easier given the low usage statistics we have for Safari. ```Error: Attribute color not allowed on element link at this point. From line 27, column 1; to line 27, column 108 st.json">↩<link rel="mask-icon" href="/jadu/bundles/pulsar/images/favicons/cms/safari-pinned-tab.svg" color="#15a6d1">↩<link Attributes for element link: Global attributes href — Address of the hyperlink crossorigin — How the element handles crossorigin requests rel — Relationship of this document (or subsection/topic) to the destination resource rev — Reverse link relationship of the destination resource to this document (or subsection/topic) media — Applicable media nonce — Cryptographic nonce used in Content Security Policy checks [CSP3] hreflang — Language of the linked resource type — Hint for the type of the referenced resource sizes — Sizes of the icons (for rel="icon") Also, the title attribute has special semantics on this element: Title of the link; alternative style sheet set name.```
Current coverage is 98.29% (diff: 100%)@@ develop #465 diff @@
==========================================
Files 15 15
Lines 585 585
Methods 29 29
Messages 0 0
Branches 0 0
==========================================
Hits 575 575
Misses 10 10
Partials 0 0
|
jamesjacobs
approved these changes
Jan 23, 2017
sideshowbarker
added a commit
to validator/validator
that referenced
this pull request
Mar 26, 2017
Fixes #174 Thanks @925dk & @XhmikosR Relates to whatwg/html#110 Relates to whatwg/html#2230 Relates to jadu/pulsar#465 See also #483
|
The HTML checker (validator) now allows this. https://validator.w3.org/nu/ and https://checker.html5.org/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
colorattribute on the<link>tag isn’t valid and throws an error in the W3C validator. This has been an ongoing discussion with the validator team and the WhatWG (For over a year).See:
Until this is resolved I see no alternative but to remove the safari pinned tab icon, which is made easier given the low usage statistics we have for Safari.
grunt realFavicontask from generating Safari pinned tab favicons