Make table detail column scroll when content exceeds viewport #818
Conversation
Change position from abolute to fixed and add overflow behaviour. Closes #814
Codecov Report
@@ Coverage Diff @@
## develop #818 +/- ##
========================================
Coverage 97.33% 97.33%
========================================
Files 55 55
Lines 1948 1948
========================================
Hits 1896 1896
Misses 52 52
Continue to review full report at Codecov.
|
Stanton
changed the title
Also add margin utility classes to separate cards
stylesheets/_utility.utilities.scss
Outdated
| @@ -333,3 +333,13 @@ div.no-results { | |||
| .u-margin-bottom-none { | |||
| margin-bottom: 0 !important; | |||
| } | |||
|
|
|||
| %u-margin-bottom-1, | |||
There was a problem hiding this comment.
What if the name was just 'u-margin-bottom' for this one and 'u-margin-bottom-2x' for the next class? With just 1 and 2 added at the end might not be clear what is their purpose.
There was a problem hiding this comment.
Yeah, I agree with @nvasileiadis I'd rather we had u-margin-bottom and u-margin-bottom--large for example. That would make it a little more consistent with other utility classes with modifiers.
stylesheets/_utility.utilities.scss
Outdated
| @@ -333,3 +333,13 @@ div.no-results { | |||
| .u-margin-bottom-none { | |||
| margin-bottom: 0 !important; | |||
| } | |||
|
|
|||
| %u-margin-bottom-1, | |||
There was a problem hiding this comment.
Yeah, I agree with @nvasileiadis I'd rather we had u-margin-bottom and u-margin-bottom--large for example. That would make it a little more consistent with other utility classes with modifiers.
Make table detail column scroll when content exceeds viewport
Change position from abolute to fixed and add overflow behaviour.
Closes #814
Before
After
Browser Testing Checklist
Breaking change quick checklist
The following points should be considered as an early-warning of introducing a breaking change to a Continuum platform product. This is not an exhaustive list of what constitutes a breaking change.
main.jsindex.jspulsar.scssgruntfile.jspackage.json(not including dev dependencies)base.html.twig(or other core views like header/footer)