Skip to content

Commit

Permalink
Downgrade urllib3 to 1.24.3 to fulfill requests@2.20.0 requirements (#83
Browse files Browse the repository at this point in the history
)

Related to #81 and #82.

I had bumped `urllib3` to the latest version at the time (`1.25.2`) in #80 to resolve a security vulnerability in `urllib3 < 1.24.2`.

However, this meant that the required `requests` version, `2.20.0` had the wrong `urllib3` version.

`urllib3@1.24.3` both avoids the security vulnerability and fulfills `requests`' `urllib3` version requirements.
  • Loading branch information
jaebradley committed Jun 5, 2019
1 parent 6e463c1 commit 7545416
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ pytest-cov==2.6.0
pytz==2018.6
requests==2.20.0
six==1.11.0
urllib3==1.25.2
urllib3==1.24.3
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name="basketball_reference_web_scraper",
version="4.2.2",
version="4.2.3",
author="Jae Bradley",
author_email="jae.b.bradley@gmail.com",
license="MIT",
Expand All @@ -22,7 +22,7 @@
"lxml==4.2.5",
"pytz==2018.6",
"requests==2.20.0",
"urllib3==1.25.2",
"urllib3==1.24.3",
],
classifiers=[
"Programming Language :: Python :: 3",
Expand Down

0 comments on commit 7545416

Please sign in to comment.