Upgrade urllib3 to 1.25.2 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #80 +/- ##
=========================================
+ Coverage 92.5% 93.15% +0.65%
=========================================
Files 12 12
Lines 307 307
Branches 38 38
=========================================
+ Hits 284 286 +2
+ Misses 19 18 -1
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
jaebradley
added a commit
that referenced
this pull request
Jun 5, 2019
) Related to #81 and #82. I had bumped `urllib3` to the latest version at the time (`1.25.2`) in #80 to resolve a security vulnerability in `urllib3 < 1.24.2`. However, this meant that the required `requests` version, `2.20.0` had the wrong `urllib3` version. `urllib3@1.24.3` both avoids the security vulnerability and fulfills `requests`' `urllib3` version requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib3 < 1.24.2has a security vulnerability.This change upgrades to the latest version of
urllib3.